From 5fde6ffa0b70c29307dceffbc19c6dd6ba288728 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 6 Oct 2004 18:20:03 +0000 Subject: [PATCH] Pop up the completions again after tab. (#147700, Jens Bech Madsen) 2004-10-06 Matthias Clasen * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up the completions again after tab. (#147700, Jens Bech Madsen) --- ChangeLog | 3 +++ ChangeLog.pre-2-10 | 3 +++ ChangeLog.pre-2-6 | 3 +++ ChangeLog.pre-2-8 | 3 +++ gtk/gtkfilechooserentry.c | 13 +++++++++---- 5 files changed, 21 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5aaee4a5c0..9838fdf302 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2004-10-06 Matthias Clasen + * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up + the completions again after tab. (#147700, Jens Bech Madsen) + * gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor before changing the selection to make the file chooser preview update work better. (#143826, Tommi Komulainen) diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 5aaee4a5c0..9838fdf302 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,5 +1,8 @@ 2004-10-06 Matthias Clasen + * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up + the completions again after tab. (#147700, Jens Bech Madsen) + * gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor before changing the selection to make the file chooser preview update work better. (#143826, Tommi Komulainen) diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 5aaee4a5c0..9838fdf302 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,5 +1,8 @@ 2004-10-06 Matthias Clasen + * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up + the completions again after tab. (#147700, Jens Bech Madsen) + * gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor before changing the selection to make the file chooser preview update work better. (#143826, Tommi Komulainen) diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 5aaee4a5c0..9838fdf302 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,5 +1,8 @@ 2004-10-06 Matthias Clasen + * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_focus): Pop up + the completions again after tab. (#147700, Jens Bech Madsen) + * gtk/gtktreeview.c (gtk_tree_view_search_iter): Set the cursor before changing the selection to make the file chooser preview update work better. (#143826, Tommi Komulainen) diff --git a/gtk/gtkfilechooserentry.c b/gtk/gtkfilechooserentry.c index 4d9a098560..18ee32b4bd 100644 --- a/gtk/gtkfilechooserentry.c +++ b/gtk/gtkfilechooserentry.c @@ -665,11 +665,16 @@ gtk_file_chooser_entry_focus (GtkWidget *widget, (GTK_WIDGET_HAS_FOCUS (widget)) && (! control_pressed)) { + gint pos = 0; + if (chooser_entry->has_completion) - { - gtk_editable_set_position (GTK_EDITABLE (widget), - GTK_ENTRY (widget)->text_length); - } + gtk_editable_set_position (GTK_EDITABLE (widget), + GTK_ENTRY (widget)->text_length); + /* Trigger the completion window to pop up again by a + * zero-length insertion, a bit of a hack. + */ + gtk_editable_insert_text (GTK_EDITABLE (widget), "", -1, &pos); + return TRUE; } else -- 2.30.2